This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch for sparc-tdep.c for NetBSD/sparc.


J.T. Conklin wrote:
> 
> >>>>> "Michael" == Michael Snyder <msnyder@cygnus.com> writes:
> >> I don't see that this is much different than the GDB_{G,FP}REGSET_T
> >> macro definitions in gregset.h.
> 
> Michael> I'm not saying "mine's better", I'm just saying when I have
> Michael> the choice to use a macro or a typedef, I prefer a typedef.
> Michael> You can say "printtype gdb_gregset_t" if it's a typedef, but
> Michael> not if it's a macro.
> 
> Agreed.  But gdb_{g,fp}regset_t will be a type, because the lines in
> gregset.h will expand from:
> 
>         typedef GDB_GREGSET_T   gdb_regset_t;
>         typedef GDB_FPREGSET_T  gdb_fpregset_t;
> 
> to:
>         typedef struct reg      gdb_regset_t;
>         typedef struct fpreg    gdb_fpregset_t;
> 
> As such, I prefer that GDB_{G,FP}REGSET_T be defined to the structs
> instead of creating types which only exists to define other types.

Oh, OK.  I'm fine with that.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]