This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH]: Remove useless variables.



2000-07-12  Michael Snyder  <msnyder@cleaver.cygnus.com>

        * regcache.c (registers_changed, registers_fetched): Use 
        ARCH_NUM_REGS directly, eliminating an unnecessary variable.

Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.3
diff -p -r1.3 regcache.c
*** regcache.c	2000/07/11 05:42:25	1.3
--- regcache.c	2000/07/12 21:05:56
*************** void
*** 282,288 ****
  registers_changed (void)
  {
    int i;
-   int numregs = ARCH_NUM_REGS;
  
    registers_pid = -1;
  
--- 282,287 ----
*************** registers_changed (void)
*** 293,299 ****
       gdb gives control to the user (ie watchpoints).  */
    alloca (0);
  
!   for (i = 0; i < numregs; i++)
      register_valid[i] = 0;
  
    if (registers_changed_hook)
--- 292,298 ----
       gdb gives control to the user (ie watchpoints).  */
    alloca (0);
  
!   for (i = 0; i < ARCH_NUM_REGS; i++)
      register_valid[i] = 0;
  
    if (registers_changed_hook)
*************** void
*** 309,317 ****
  registers_fetched (void)
  {
    int i;
-   int numregs = ARCH_NUM_REGS;
  
!   for (i = 0; i < numregs; i++)
      register_valid[i] = 1;
  }
  
--- 308,315 ----
  registers_fetched (void)
  {
    int i;
  
!   for (i = 0; i < ARCH_NUM_REGS; i++)
      register_valid[i] = 1;
  }
  
*************** read_register_bytes (int inregbyte, char
*** 368,374 ****
  	/* The range the user wants to read doesn't overlap with regno.  */
  	continue;
  
!       /* We've found an invalid register where at least one byte will be read.
           Update it from the target.  */
        target_fetch_registers (regno);
  
--- 366,372 ----
  	/* The range the user wants to read doesn't overlap with regno.  */
  	continue;
  
!       /* We've found an uncached register where at least one byte will be read.
           Update it from the target.  */
        target_fetch_registers (regno);
  
*************** read_register_gen (int regno, char *myad
*** 395,401 ****
      }
  
    if (!register_valid[regno])
!     target_fetch_registers (regno);
    memcpy (myaddr, &registers[REGISTER_BYTE (regno)],
  	  REGISTER_RAW_SIZE (regno));
  }
--- 393,401 ----
      }
  
    if (!register_valid[regno])
!     {
!       target_fetch_registers (regno);
!     }
    memcpy (myaddr, &registers[REGISTER_BYTE (regno)],
  	  REGISTER_RAW_SIZE (regno));
  }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]