This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH] (try #2) cleanup section_addr_info struct
- To: Elena Zannoni <ezannoni at cygnus dot com>
- Subject: Re: [PATCH] (try #2) cleanup section_addr_info struct
- From: Jim Blandy <jimb at zwingli dot cygnus dot com>
- Date: 14 Apr 2000 15:38:03 -0500
- Cc: gdb-patches at sourceware dot cygnus dot com
- References: <14583.21953.458777.593608@kwikemart.cygnus.com>
Approved, with one change:
Could you rename the only remaining member of `struct
section_addr_info' to `sections'? It's kind of odd to have a
structure with only one member, named `other'. :)
The following would also be nice, but I don't know how tight your
schedule is:
Instead of duplicating all these search loops everywhere, could you
wrap up that logic in a little function or two in symfile.c, and then
use it in the appropriate places?
In general, I'm astonished that you only needed to add one search to
all of GDB. This means that those three fixed fields were only ever
used in that one place. What a waste!