This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
RFA: Remove BINOP_SCOPE
- To: David Taylor <taylor at cygnus dot com>
- Subject: RFA: Remove BINOP_SCOPE
- From: Jim Blandy <jimb at cygnus dot com>
- Date: Mon, 4 Oct 1999 19:55:17 -0500 (EST)
- CC: gdb-patches at sourceware dot cygnus dot com
GDB: Always good for a laugh.
May I commit this, David?
1999-10-04 Jim Blandy <jimb@zwingli.cygnus.com>
Remove all traces of the BINOP_SCOPE operator. It's never
generated, and not implemented.
* expression.h (enum exp_opcode): Delete BINOP_SCOPE.
* c-lang.c (c_op_print_tab): Delete entry for BINOP_SCOPE.
* eval.c (evaluate_subexp_standard): Doc fix.
* expprint.c (op_name): Remove case for BINOP_SCOPE.
(dump_subexp): Same.
Index: expression.h
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/expression.h,v
retrieving revision 1.44
diff -c -r1.44 expression.h
*** expression.h 1999/07/07 23:51:07 1.44
--- expression.h 1999/10/05 00:46:00
***************
*** 78,84 ****
BINOP_MIN, /* <? */
BINOP_MAX, /* >? */
- BINOP_SCOPE, /* :: */
/* STRUCTOP_MEMBER is used for pointer-to-member constructs.
X . * Y translates into X STRUCTOP_MEMBER Y. */
--- 78,83 ----
Index: c-lang.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/c-lang.c,v
retrieving revision 2.26
diff -c -r2.26 c-lang.c
*** c-lang.c 1999/07/07 23:51:03 2.26
--- c-lang.c 1999/10/05 00:46:01
***************
*** 389,396 ****
{"sizeof ", UNOP_SIZEOF, PREC_PREFIX, 0},
{"++", UNOP_PREINCREMENT, PREC_PREFIX, 0},
{"--", UNOP_PREDECREMENT, PREC_PREFIX, 0},
- /* C++ */
- {"::", BINOP_SCOPE, PREC_PREFIX, 0},
{NULL, 0, 0, 0}
};
--- 389,394 ----
Index: eval.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/eval.c,v
retrieving revision 1.104
diff -c -r1.104 eval.c
*** eval.c 1999/09/01 20:27:21 1.104
--- eval.c 1999/10/05 00:46:03
***************
*** 1738,1746 ****
default:
/* Removing this case and compiling with gcc -Wall reveals that
a lot of cases are hitting this case. Some of these should
! probably be removed from expression.h (e.g. do we need a BINOP_SCOPE
! and an OP_SCOPE?); others are legitimate expressions which are
! (apparently) not fully implemented.
If there are any cases landing here which mean a user error,
then they should be separate cases, with more descriptive
--- 1738,1745 ----
default:
/* Removing this case and compiling with gcc -Wall reveals that
a lot of cases are hitting this case. Some of these should
! probably be removed from expression.h; others are legitimate
! expressions which are (apparently) not fully implemented.
If there are any cases landing here which mean a user error,
then they should be separate cases, with more descriptive
Index: expprint.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/expprint.c,v
retrieving revision 1.60
diff -c -r1.60 expprint.c
*** expprint.c 1999/08/31 05:28:13 1.60
--- expprint.c 1999/10/05 00:46:04
***************
*** 575,582 ****
return "BINOP_MIN";
case BINOP_MAX:
return "BINOP_MAX";
- case BINOP_SCOPE:
- return "BINOP_SCOPE";
case STRUCTOP_MEMBER:
return "STRUCTOP_MEMBER";
case STRUCTOP_MPTR:
--- 575,580 ----
***************
*** 790,796 ****
case BINOP_EXP:
case BINOP_MIN:
case BINOP_MAX:
- case BINOP_SCOPE:
case BINOP_INTDIV:
case BINOP_ASSIGN_MODIFY:
case BINOP_VAL:
--- 788,793 ----