This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Fun fun, monitor.c -Werror -Wformat


Hello,

Wed Sep  1 13:16:49 1999  Andrew Cagney  <cagney@b1.cygnus.com>

        * Makefile.in (monitor.o): For moment, don't try to compile with
        -Werror.  monitor.c has -Wformat problems.  See Makefile.in for
        more info.

I'm about to check in the attached patch.  It avoids trying to compile
the file monitor.c with -Werror (to the best of my knowledge I'm
responsible for that file since I'm responsible for remote.c).

My reasoning is that fixing this file takes more than just a few printf
parameter tweeks.  Proper testing with a monitor board is required.  For
the moment, I'd rather spend time ensuring that all the other
targets/files pass -Wformat -Werror rather than hold the process back
for this one file.

Comments and complaints?

If someone would like to step up and fix this file than, I suspect,
everyone would be appreciative.  Failing that I'll get around to it in a
few weeks/months.

	Andrew
? diffs
Index: ChangeLog
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/ChangeLog,v
retrieving revision 1.5354
diff -p -r1.5354 ChangeLog
*** ChangeLog	1999/09/01 02:53:15	1.5354
--- ChangeLog	1999/09/01 03:24:40
***************
*** 1,3 ****
--- 1,8 ----
+ Wed Sep  1 13:16:49 1999  Andrew Cagney  <cagney@b1.cygnus.com>
+ 
+ 	* Makefile.in (monitor.o): Don't try to compile with -Werror.
+   	monitor.c has -Wformat problems.  See Makefile.in for more info.
+ 
  Wed Sep  1 09:22:50 1999  Andrew Cagney  <cagney@b1.cygnus.com>
  
  	* d30v-tdep.c (d30v_print_register): 
Index: Makefile.in
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/Makefile.in,v
retrieving revision 1.697
diff -p -r1.697 Makefile.in
*** Makefile.in	1999/08/31 22:34:03	1.697
--- Makefile.in	1999/09/01 03:24:44
*************** mipsread.o: mipsread.c buildsym.h compla
*** 1459,1466 ****
--- 1459,1472 ----
  
  mipsv4-nat.o: mipsv4-nat.c $(defs_h) $(gdbcore_h) $(inferior_h) target.h
  
+ # FIXME: Monitor.c has -Wformat problems.  The code using the macros
+ # RDEBUG and EXTRA_RDEBUG needs be replaced with something: that
+ # doesn't cause -Wformat errors; sends all output to gdb_stdlog
+ # instead of stdout; and controls the output throug a ``set
+ # monitordebug'' command/variable. cagney, 1999-09-01.
  monitor.o: monitor.c monitor.h $(bfd_h) $(wait_h) $(defs_h) $(gdbcmd_h) \
  	$(inferior_h) target.h serial.h terminal.h gdb_string.h
+ 	$(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) $<
  
  news-xdep.o: news-xdep.c
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]