Re: Patch to speed up remote protocol

[jtc@redback.com (J.T. Conklin)]

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
Andrew> Attached is a patch that integrates your change into a general
Andrew> cleanup of ``P'' packet support code.  The patch adds the
Andrew> commands:
Andrew>
Andrew> 	set stub-supports-P-packet {supported,unsupported,auto}
Andrew>		show stub-supports-P-packet
Andrew>
Andrew> so explicit examination/control is also possible.  (I'm very
Andrew> interested in suggestions for a better variable name).  The
Andrew> bulk of the code is also generic so that it can be re-used by
Andrew> code detecting other optional packets.

I'm not sure I like the idea of setting GDB's support of the P packet
from the CLI.  If it can be autonegotiated successfully (which my
experience has shown to be true), there doesn't seem to be a need.  I
do agree that once a stub accepts 'P', it should be expected to always
support it within that debugging session.

As for names, it probably should have "remote" in the name to tie it
to the other remote protocol variables.  Perhaps:

	remote-stub-supports-P-packet
	remote-protocol-supports-P-packet
	remote-protocol-supports-register-set

But that's only if there really is a need for this variable.  We
shouldn't add knobs just because we can.

	--jtc

-- 
J.T. Conklin
RedBack Networks