This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove some defines from tui-data.h
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 20 Aug 2019 22:50:20 -0000
- Subject: [binutils-gdb] Remove some defines from tui-data.h
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=072272ce055b0234ee9622a80d217f9d1f8083b3
commit 072272ce055b0234ee9622a80d217f9d1f8083b3
Author: Tom Tromey <tom@tromey.com>
Date: Sat Jul 13 18:30:53 2019 -0600
Remove some defines from tui-data.h
This removes the HILITE and NO_HILITE defines from tui-data.h, in
favor of simply passing a bool to box_win.
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
(tui_unhighlight_win, tui_highlight_win)
(tui_win_info::make_window): Update.
* tui/tui-data.h (HILITE, NO_HILITE): Remove.
Diff:
---
gdb/ChangeLog | 7 +++++++
gdb/tui/tui-data.h | 2 --
gdb/tui/tui-wingeneral.c | 10 +++++-----
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ea22847..b8b062f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2019-08-20 Tom Tromey <tom@tromey.com>
+ * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
+ (tui_unhighlight_win, tui_highlight_win)
+ (tui_win_info::make_window): Update.
+ * tui/tui-data.h (HILITE, NO_HILITE): Remove.
+
+2019-08-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
(MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
(MAX_PID_WIDTH): Move to tui-stack.c.
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index dda15d1..6dfea41 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -102,8 +102,6 @@ public:
#define CMD_NAME "cmd"
#define DATA_NAME "regs"
#define DISASSEM_NAME "asm"
-#define HILITE TRUE
-#define NO_HILITE FALSE
#define MIN_WIN_HEIGHT 3
#define MIN_CMD_WIN_HEIGHT 3
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index 5fa4cfd..ab0363f 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -56,7 +56,7 @@ tui_delete_win (WINDOW *window)
/* Draw a border arround the window. */
static void
box_win (struct tui_win_info *win_info,
- int highlight_flag)
+ bool highlight_flag)
{
if (win_info && win_info->handle)
{
@@ -64,7 +64,7 @@ box_win (struct tui_win_info *win_info,
int attrs;
win = win_info->handle;
- if (highlight_flag == HILITE)
+ if (highlight_flag)
attrs = tui_active_border_attrs;
else
attrs = tui_border_attrs;
@@ -92,7 +92,7 @@ tui_unhighlight_win (struct tui_win_info *win_info)
&& win_info->can_highlight
&& win_info->handle != NULL)
{
- box_win (win_info, NO_HILITE);
+ box_win (win_info, false);
win_info->refresh_window ();
win_info->set_highlight (false);
}
@@ -106,7 +106,7 @@ tui_highlight_win (struct tui_win_info *win_info)
&& win_info->can_highlight
&& win_info->handle != NULL)
{
- box_win (win_info, HILITE);
+ box_win (win_info, true);
win_info->refresh_window ();
win_info->set_highlight (true);
}
@@ -138,7 +138,7 @@ tui_win_info::make_window ()
{
tui_gen_win_info::make_window ();
if (handle != NULL && can_box ())
- box_win (this, NO_HILITE);
+ box_win (this, false);
}
/* We can't really make windows visible, or invisible. So we have to