[binutils-gdb] Remove readline hack from gdb_select

[Tom Tromey <tromey at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5db2718ce48c497e317787caebacd019da59c3b0

commit 5db2718ce48c497e317787caebacd019da59c3b0
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Aug 4 17:39:27 2019 -0600

    Remove readline hack from gdb_select
    
    As discussed on gdb-patches, this removes the readline hack from the
    mingw-hdep.c version of gdb_select.  It's believed that this is not
    needed any more.  See:
    
        https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html
    
    gdb/ChangeLog
    2019-08-12  Tom Tromey  <tom@tromey.com>
    
    	* mingw-hdep.c (gdb_select): Remove readline hack.

Diff:
---
 gdb/ChangeLog    | 4 ++++
 gdb/mingw-hdep.c | 9 ---------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4008783..e134155 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-12  Tom Tromey  <tom@tromey.com>
+
+	* mingw-hdep.c (gdb_select): Remove readline hack.
+
 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 
 	* blockframe.c (find_pc_partial_function): Set *block to nullptr
diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c
index 8ed4b44..44fb22e 100644
--- a/gdb/mingw-hdep.c
+++ b/gdb/mingw-hdep.c
@@ -23,7 +23,6 @@
 #include "event-loop.h"
 
 #include "gdb_select.h"
-#include "readline/readline.h"
 
 #include <windows.h>
 
@@ -167,14 +166,6 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
 	}
     }
 
-  /* With multi-threaded SIGINT handling, there is a race between the
-     readline signal handler and GDB.  It may still be in
-     rl_prep_terminal in another thread.  Do not return until it is
-     done; we can check the state here because we never longjmp from
-     signal handlers on Windows.  */
-  while (RL_ISSTATE (RL_STATE_SIGHANDLER))
-    Sleep (1);
-
   return num_ready;
 }