This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] [gdb/testsuite] Fix gdb.base/break-probes.exp with native-gdbserver


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=36cd4ba59817473935f781174744e7883ff221ee

commit 36cd4ba59817473935f781174744e7883ff221ee
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Apr 18 23:37:33 2019 +0200

    [gdb/testsuite] Fix gdb.base/break-probes.exp with native-gdbserver
    
    When running break-probes.exp with native-gdbserver, we run into:
    ...
    FAIL: gdb.base/break-probes.exp: run til our library loads (the program exited)
    FAIL: gdb.base/break-probes.exp: call (int) foo(23)
    ...
    due to the fact that we're trying to match:
    ...
    Inferior loaded /data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
      /break-probes/break-probes-solib.so
    ...
    using pattern:
    ...
    Inferior loaded $sysroot$binfile_lib
    ...
    which expands into:
    ...
    Inferior loaded //data/gdb_versions/devel/build/gdb/testsuite/outputs/gdb.base\
      /break-probes/break-probes-solib.so
    ...
    
    Fix by setting sysroot to "" in local-board.exp.
    
    Tested on x86_64-linux with native-gdbserver.
    
    gdb/testsuite/ChangeLog:
    
    2019-04-18  Tom de Vries  <tdevries@suse.de>
    
    	PR gdb/24433
    	* boards/local-board.exp: Set sysroot to "".

Diff:
---
 gdb/testsuite/ChangeLog              | 5 +++++
 gdb/testsuite/boards/local-board.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index bdabbba..297e2d4 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,4 +1,9 @@
 2019-04-18  Tom de Vries  <tdevries@suse.de>
+
+	PR gdb/24433
+	* boards/local-board.exp: Set sysroot to "".
+
+2019-04-18  Tom de Vries  <tdevries@suse.de>
 	    Pedro Alves  <palves@redhat.com>
 
 	PR gdb/24454
diff --git a/gdb/testsuite/boards/local-board.exp b/gdb/testsuite/boards/local-board.exp
index bf710f4..6e0448c 100644
--- a/gdb/testsuite/boards/local-board.exp
+++ b/gdb/testsuite/boards/local-board.exp
@@ -24,4 +24,4 @@ set baseboard [lindex [split $board "/"] 0]
 set board_info($baseboard,isremote) 0
 
 # Set sysroot to avoid sending files via the remote protocol.
-set GDBFLAGS "${GDBFLAGS} -ex \"set sysroot /\""
+set GDBFLAGS "${GDBFLAGS} -ex \"set sysroot\""


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]