This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix wrong format specification in display_selector()
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 17 Mar 2019 18:42:18 -0000
- Subject: [binutils-gdb] Fix wrong format specification in display_selector()
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fce4c071610c0d01b70b172ee538e831023c1c2f
commit fce4c071610c0d01b70b172ee538e831023c1c2f
Author: Ð?ладимиÑ? Ð?аÑ?Ñ?Ñ?Ñ?нов <vilgeforce@gmail.com>
Date: Sun Mar 17 12:48:24 2019 +0300
Fix wrong format specification in display_selector()
There are a wrong format strings in function display_selector() in
file windows-nat.c. This leads to build error using Cygwin on Windows.
LDT_ENTRY.HighWord is a DWORD, which is unsigned long int, so the
format specification should be for long int, not simply int.
gdb/ChangeLog:
2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
PR gdb/24351
* windows-nat.c (display_selector): Format specifications fixed
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/windows-nat.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 517d666..478ff0a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
+
+ PR gdb/24351
+ * windows-nat.c (display_selector): Fix format specifiers.
+
2019-03-17 Eli Zaretskii <eliz@gnu.org>
* tui/tui-winsource.c (tui_set_is_exec_point_at): Call
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 5caaa3b..c8acadd 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1097,14 +1097,14 @@ display_selector (HANDLE thread, DWORD sel)
puts_filtered ("Code (Exec/Read, Conf");
break;
default:
- printf_filtered ("Unknown type 0x%x",info.HighWord.Bits.Type);
+ printf_filtered ("Unknown type 0x%lx",info.HighWord.Bits.Type);
}
if ((info.HighWord.Bits.Type & 0x1) == 0)
puts_filtered(", N.Acc");
puts_filtered (")\n");
if ((info.HighWord.Bits.Type & 0x10) == 0)
puts_filtered("System selector ");
- printf_filtered ("Priviledge level = %d. ", info.HighWord.Bits.Dpl);
+ printf_filtered ("Priviledge level = %ld. ", info.HighWord.Bits.Dpl);
if (info.HighWord.Bits.Granularity)
puts_filtered ("Page granular.\n");
else