This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove some unneeded initializations in minimal_symbol_reader
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 15 Mar 2019 22:07:57 -0000
- Subject: [binutils-gdb] Remove some unneeded initializations in minimal_symbol_reader
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=788c80d1aff685e66b8105ddc7451cfa6a03bf1d
commit 788c80d1aff685e66b8105ddc7451cfa6a03bf1d
Author: Tom Tromey <tom@tromey.com>
Date: Fri Mar 1 19:56:45 2019 -0700
Remove some unneeded initializations in minimal_symbol_reader
minimal_symbol_reader::record_full does not need to initialize any
minsym fields to 0, because that was already done implicitly via the
use of XCNEW when allocating the msym_bunch.
gdb/ChangeLog
2019-03-15 Tom Tromey <tom@tromey.com>
* minsyms.c (minimal_symbol_reader::record_full): Remove some
initializations.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/minsyms.c | 10 ----------
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 867df17..ceedf53 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-03-15 Tom Tromey <tom@tromey.com>
+ * minsyms.c (minimal_symbol_reader::record_full): Remove some
+ initializations.
+
+2019-03-15 Tom Tromey <tom@tromey.com>
+
* objfiles.h (struct objfile_per_bfd_storage)
<demangled_hash_languages>: Now a bitset.
* minsyms.c (add_minsym_to_demangled_hash_table): Update.
diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index cbb45f1..bc6e536 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -1163,16 +1163,6 @@ minimal_symbol_reader::record_full (const char *name, int name_len,
MSYMBOL_SECTION (msymbol) = section;
MSYMBOL_TYPE (msymbol) = ms_type;
- MSYMBOL_TARGET_FLAG_1 (msymbol) = 0;
- MSYMBOL_TARGET_FLAG_2 (msymbol) = 0;
- /* Do not use the SET_MSYMBOL_SIZE macro to initialize the size,
- as it would also set the has_size flag. */
- msymbol->size = 0;
-
- /* The hash pointers must be cleared! If they're not,
- add_minsym_to_hash_table will NOT add this msymbol to the hash table. */
- msymbol->hash_next = NULL;
- msymbol->demangled_hash_next = NULL;
/* If we already read minimal symbols for this objfile, then don't
ever allocate a new one. */