This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Split rank_one_type_parm_array from rank_one_type
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 9 Mar 2019 13:30:03 -0000
- Subject: [binutils-gdb] Split rank_one_type_parm_array from rank_one_type
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b9f4512f250f7fa685f1f888b6fcbe2e34dc9733
commit b9f4512f250f7fa685f1f888b6fcbe2e34dc9733
Author: Simon Marchi <simon.marchi@efficios.com>
Date: Fri Mar 8 10:15:08 2019 -0500
Split rank_one_type_parm_array from rank_one_type
gdb/ChangeLog:
* gdbtypes.c (rank_one_type_parm_array): New function extracted
from...
(rank_one_type): ... this.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/gdbtypes.c | 26 +++++++++++++++++---------
2 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4afd9b6..c3d381a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2019-03-08 Simon Marchi <simon.marchi@efficios.com>
+ * gdbtypes.c (rank_one_type_parm_array): New function extracted
+ from...
+ (rank_one_type): ... this.
+
+2019-03-08 Simon Marchi <simon.marchi@efficios.com>
+
* gdbtypes.c (rank_one_type_parm_ptr): New function extracted
from...
(rank_one_type): ... this.
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index b4b9273..a9a1238 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -3857,6 +3857,22 @@ rank_one_type_parm_ptr (struct type *parm, struct type *arg, struct value *value
}
}
+/* rank_one_type helper for when PARM's type code is TYPE_CODE_ARRAY. */
+
+static struct rank
+rank_one_type_parm_array (struct type *parm, struct type *arg, struct value *value)
+{
+ switch (TYPE_CODE (arg))
+ {
+ case TYPE_CODE_PTR:
+ case TYPE_CODE_ARRAY:
+ return rank_one_type (TYPE_TARGET_TYPE (parm),
+ TYPE_TARGET_TYPE (arg), NULL);
+ default:
+ return INCOMPATIBLE_TYPE_BADNESS;
+ }
+}
+
/* Compare one type (PARM) for compatibility with another (ARG).
* PARM is intended to be the parameter type of a function; and
* ARG is the supplied argument's type. This function tests if
@@ -3949,15 +3965,7 @@ rank_one_type (struct type *parm, struct type *arg, struct value *value)
case TYPE_CODE_PTR:
return rank_one_type_parm_ptr (parm, arg, value);
case TYPE_CODE_ARRAY:
- switch (TYPE_CODE (arg))
- {
- case TYPE_CODE_PTR:
- case TYPE_CODE_ARRAY:
- return rank_one_type (TYPE_TARGET_TYPE (parm),
- TYPE_TARGET_TYPE (arg), NULL);
- default:
- return INCOMPATIBLE_TYPE_BADNESS;
- }
+ return rank_one_type_parm_array (parm, arg, value);
case TYPE_CODE_FUNC:
switch (TYPE_CODE (arg))
{