This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Change create_demangled_names_hash to take an objfile_per_bfd_storage


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0f14768a2a6ba894ae81010e8e70c99ecdb39a73

commit 0f14768a2a6ba894ae81010e8e70c99ecdb39a73
Author: Tom Tromey <tom@tromey.com>
Date:   Thu May 10 16:23:48 2018 -0600

    Change create_demangled_names_hash to take an objfile_per_bfd_storage
    
    This changes create_demangled_names_hash to take an
    objfile_per_bfd_storage parameter.  This makes it clearer where it is
    storing the objects it allocates.
    
    gdb/ChangeLog
    2019-01-10  Tom Tromey  <tom@tromey.com>
    
    	* symtab.c (create_demangled_names_hash): Change argument to be an
    	objfile_per_bfd_storage.
    	(symbol_set_names): Update.

Diff:
---
 gdb/ChangeLog | 6 ++++++
 gdb/symtab.c  | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e0cf7cb..25a219f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-01-10  Tom Tromey  <tom@tromey.com>
 
+	* symtab.c (create_demangled_names_hash): Change argument to be an
+	objfile_per_bfd_storage.
+	(symbol_set_names): Update.
+
+2019-01-10  Tom Tromey  <tom@tromey.com>
+
 	* xcoffread.c (xcoff_initial_scan): Unconditionally call
 	init_psymbol_list.
 	* psymtab.c (init_psymbol_list): Do nothing if already called.
diff --git a/gdb/symtab.c b/gdb/symtab.c
index c4343cd..3f15dbd 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -707,14 +707,14 @@ eq_demangled_name_entry (const void *a, const void *b)
    name.  The entry is hashed via just the mangled name.  */
 
 static void
-create_demangled_names_hash (struct objfile *objfile)
+create_demangled_names_hash (struct objfile_per_bfd_storage *per_bfd)
 {
   /* Choose 256 as the starting size of the hash table, somewhat arbitrarily.
      The hash table code will round this up to the next prime number.
      Choosing a much larger table size wastes memory, and saves only about
      1% in symbol reading.  */
 
-  objfile->per_bfd->demangled_names_hash = htab_create_alloc
+  per_bfd->demangled_names_hash = htab_create_alloc
     (256, hash_demangled_name_entry, eq_demangled_name_entry,
      NULL, xcalloc, xfree);
 }
@@ -801,7 +801,7 @@ symbol_set_names (struct general_symbol_info *gsymbol,
     }
 
   if (per_bfd->demangled_names_hash == NULL)
-    create_demangled_names_hash (objfile);
+    create_demangled_names_hash (per_bfd);
 
   if (linkage_name[len] != '\0')
     {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]