This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] gdb/riscv: Format CORE_ADDR as a string for printing
- From: Andrew Burgess <aburgess at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 21 Dec 2018 17:09:25 -0000
- Subject: [binutils-gdb] gdb/riscv: Format CORE_ADDR as a string for printing
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a96bd1ccc0dca2d260e0e30de462f37066973ceb
commit a96bd1ccc0dca2d260e0e30de462f37066973ceb
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date: Fri Dec 21 00:48:51 2018 +0000
gdb/riscv: Format CORE_ADDR as a string for printing
Avoid compiler errors caused by trying to print CORE_ADDR using '%ld'
format, instead convert to a string and print that instead.
gdb/ChangeLog:
* riscv-tdep.c (riscv_scan_prologue): Use plongest to format
a signed offset as a string.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/riscv-tdep.c | 14 ++++++++++----
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 953bc17..900a4c7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-21 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * riscv-tdep.c (riscv_scan_prologue): Use plongest to format
+ a signed offset as a string.
+
2018-12-21 Dave Murphy <davem@devkitpro.org>
* dtrace-probe.c (dtrace_static_probe_ops): Explicit zero
diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
index 88b79af..6a55ab8 100644
--- a/gdb/riscv-tdep.c
+++ b/gdb/riscv-tdep.c
@@ -1542,10 +1542,16 @@ riscv_scan_prologue (struct gdbarch *gdbarch,
if (stack.find_reg (gdbarch, i, &offset))
{
if (riscv_debug_unwinder)
- fprintf_unfiltered (gdb_stdlog,
- "Register $%s at stack offset %ld\n",
- gdbarch_register_name (gdbarch, i),
- offset);
+ {
+ /* Display OFFSET as a signed value, the offsets are from
+ the frame base address to the registers location on
+ the stack, with a descending stack this means the
+ offsets are always negative. */
+ fprintf_unfiltered (gdb_stdlog,
+ "Register $%s at stack offset %s\n",
+ gdbarch_register_name (gdbarch, i),
+ plongest ((LONGEST) offset));
+ }
trad_frame_set_addr (cache->regs, i, offset);
}
}