This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix asm in testsuite/gdb.arch/aarch64-fp.c
- From: Alan Hayward <alahay01 at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 17 Aug 2018 10:10:50 -0000
- Subject: [binutils-gdb] Fix asm in testsuite/gdb.arch/aarch64-fp.c
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2ecae92e2372102ac0fa774fce4c4c0d6f8c85f5
commit 2ecae92e2372102ac0fa774fce4c4c0d6f8c85f5
Author: Alan Hayward <alan.hayward@arm.com>
Date: Thu Aug 16 15:21:15 2018 +0100
Fix asm in testsuite/gdb.arch/aarch64-fp.c
Cannot assume result of first and third ldr will go into x0.
Rewrite asm to be clearer.
gdb/testsuite/
PR gdb/18931:
* gdb.arch/aarch64-fp.c (main): Fix asm registers.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.arch/aarch64-fp.c | 16 +++++++++++-----
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 84ef82f..705e5f0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-17 Alan Hayward <alan.hayward@arm.com>
+
+ PR gdb/18931
+ * gdb.arch/aarch64-fp.c (main): Fix asm registers.
+
2018-08-16 Keith Seitz <keiths@redhat.com>
* gdb.compile/compile.exp: Use gdb_test_no_output for "compile code"
diff --git a/gdb/testsuite/gdb.arch/aarch64-fp.c b/gdb/testsuite/gdb.arch/aarch64-fp.c
index 0ff8e00..7eb6df2 100644
--- a/gdb/testsuite/gdb.arch/aarch64-fp.c
+++ b/gdb/testsuite/gdb.arch/aarch64-fp.c
@@ -26,12 +26,18 @@ main (void)
void *addr;
addr = &buf0[0];
- __asm __volatile ("ldr %x0, [%1]" : "=r" (val) : "r" (&addr));
- __asm __volatile ("ldr q0, [x0]");
-
+ __asm __volatile ("ldr %x0, [%1]\n\t"
+ "ldr q0, [%x0]"
+ : "=r" (val)
+ : "r" (&addr)
+ : "q0" );
+
addr = &buf1[0];
- __asm __volatile ("ldr %x0, [%1]" : "=r" (val) : "r" (&addr));
- __asm __volatile ("ldr q1, [x0]");
+ __asm __volatile ("ldr %x0, [%1]\n\t"
+ "ldr q1, [%x0]"
+ : "=r" (val)
+ : "r" (&addr)
+ : "q1" );
return 1;
}