This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix crash with -D_GLIBCXX_DEBUG
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 30 Jul 2018 14:46:00 -0000
- Subject: [binutils-gdb] Fix crash with -D_GLIBCXX_DEBUG
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=463c08d160e55d6eaf0f9bc3729781ce90f4de3f
commit 463c08d160e55d6eaf0f9bc3729781ce90f4de3f
Author: Tom Tromey <tom@tromey.com>
Date: Thu Jul 19 21:10:09 2018 -0600
Fix crash with -D_GLIBCXX_DEBUG
I noticed a buildbot failure where gdb crashed in info-os.exp, when
compiled with -D_GLIBCXX_DEBUG:
(gdb) info os procgroups
/usr/include/c++/7/bits/stl_algo.h:4834:
Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).
Objects involved in the operation:
iterator::value_type "< operator type" {
type = pid_pgid_entry;
}
The bug here is that pid_pgid_entry::operator< violates the C++
irreflexivity rule; that is, that an object cannot be less than
itself.
Tested locally by re-running info-os.exp.
gdb/ChangeLog
2018-07-30 Tom Tromey <tom@tromey.com>
* nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
irreflexivity violation.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/nat/linux-osdata.c | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2cd7d64..24ffeec 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2018-07-30 Tom Tromey <tom@tromey.com>
+ * nat/linux-osdata.c (pid_pgid_entry::operator<): Fix
+ irreflexivity violation.
+
+2018-07-30 Tom Tromey <tom@tromey.com>
+
* cli/cli-decode.c (lookup_cmd): Remove lint code.
* value.c (unpack_long): Remove lint code.
* valops.c (value_ind): Remove lint code.
diff --git a/gdb/nat/linux-osdata.c b/gdb/nat/linux-osdata.c
index 25e895d..2323dcc 100644
--- a/gdb/nat/linux-osdata.c
+++ b/gdb/nat/linux-osdata.c
@@ -415,9 +415,11 @@ struct pid_pgid_entry
/* Process group leaders always come first... */
if (this->is_leader ())
- return true;
-
- if (other.is_leader ())
+ {
+ if (!other.is_leader ())
+ return true;
+ }
+ else if (other.is_leader ())
return false;
/* ...else sort by PID. */