This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove declarations from m32c-tdep.c


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=374fd1fd7b9bbefc15c003f14f4229ccbfc1bfc8

commit 374fd1fd7b9bbefc15c003f14f4229ccbfc1bfc8
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jul 8 12:17:23 2018 -0600

    Remove declarations from m32c-tdep.c
    
    This removes some unused declarations from m32c-tdep.c.  Initially I
    had thought that this entire code block was dead, but Simon pointed
    out that it is not; so this patch simply removes some declarations.
    
    gdb/ChangeLog
    2018-07-22  Tom Tromey  <tom@tromey.com>
    
    	* m32c-tdep.c (mark_dma): Return void.
    	(make_regs): Remove unused declarations.

Diff:
---
 gdb/ChangeLog   |  5 +++++
 gdb/m32c-tdep.c | 25 ++++++++++++-------------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 68edfcf..a05f459 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2018-07-22  Tom Tromey  <tom@tromey.com>
 
+	* m32c-tdep.c (mark_dma): Return void.
+	(make_regs): Remove unused declarations.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
 	* guile/scm-cmd.c (gdbscm_dont_repeat): Call
 	cmdscm_get_valid_command_smob_arg_unsafe for effect.
 	* guile/scm-block.c (gdbscm_make_block_syms_iter): Call
diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c
index f696568..fc6277e 100644
--- a/gdb/m32c-tdep.c
+++ b/gdb/m32c-tdep.c
@@ -689,12 +689,11 @@ mark_general (struct m32c_reg *reg)
 }
 
 
-/* Mark REG as a DMA register, and return it.  */
-static struct m32c_reg *
+/* Mark REG as a DMA register.  */
+static void
 mark_dma (struct m32c_reg *reg)
 {
   reg->dma_p = 1;
-  return reg;
 }
 
 
@@ -841,16 +840,16 @@ make_regs (struct gdbarch *arch)
 
   if (mach == bfd_mach_m32c)
     {
-      struct m32c_reg *svf     = S (R16U (svf));
-      struct m32c_reg *svp     = S (RC (svp));
-      struct m32c_reg *vct     = S (RC (vct));
-
-      struct m32c_reg *dmd01   = DMA (RP (dmd, tdep->uint8));
-      struct m32c_reg *dct01   = DMA (RP (dct, tdep->uint16));
-      struct m32c_reg *drc01   = DMA (RP (drc, tdep->uint16));
-      struct m32c_reg *dma01   = DMA (RP (dma, tdep->data_addr_reg_type));
-      struct m32c_reg *dsa01   = DMA (RP (dsa, tdep->data_addr_reg_type));
-      struct m32c_reg *dra01   = DMA (RP (dra, tdep->data_addr_reg_type));
+      S (R16U (svf));
+      S (RC (svp));
+      S (RC (vct));
+
+      DMA (RP (dmd, tdep->uint8));
+      DMA (RP (dct, tdep->uint16));
+      DMA (RP (drc, tdep->uint16));
+      DMA (RP (dma, tdep->data_addr_reg_type));
+      DMA (RP (dsa, tdep->data_addr_reg_type));
+      DMA (RP (dra, tdep->data_addr_reg_type));
     }
 
   num_raw_regs = tdep->num_regs;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]