This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Add missing ATTRIBUTE_NORETURNs


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=621846f4e258167be2147894e013c85e42de1447

commit 621846f4e258167be2147894e013c85e42de1447
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Sep 27 11:23:49 2016 -0600

    Add missing ATTRIBUTE_NORETURNs
    
    This patch adds a missing ATTRIBUTE_NORETURN.  This lets
    -Wimplicit-fallthrough recognize that a given case does not fall
    through.
    
    ChangeLog
    2018-05-04  Tom Tromey  <tom@tromey.com>
    
    	* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.

Diff:
---
 gdb/ChangeLog   | 4 ++++
 gdb/dwarf2loc.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b7ae0e3..d627749 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2018-05-04  Tom Tromey  <tom@tromey.com>
 
+	* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
+
+2018-05-04  Tom Tromey  <tom@tromey.com>
+
 	* s390-tdep.c (s390_process_record): Fix fall-through comments.
 	* xcoffread.c (scan_xcoff_symtab): Move comment later.
 	* symfile.c (section_is_mapped): Fix fall-through comment.
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 78d4668..6ecc5a9 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -2865,7 +2865,7 @@ dwarf2_loc_desc_get_symbol_read_needs (const gdb_byte *data, size_t size,
 /* A helper function that throws an unimplemented error mentioning a
    given DWARF operator.  */
 
-static void
+static void ATTRIBUTE_NORETURN
 unimplemented (unsigned int op)
 {
   const char *name = get_DW_OP_name (op);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]