This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc
- From: Andrew Burgess <aburgess at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 3 Feb 2018 16:57:15 -0000
- Subject: [binutils-gdb] gdb/testsuite: Remove use of dejagnu cleanup proc
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f721678315fc6bbec25341bd616a906976d72693
commit f721678315fc6bbec25341bd616a906976d72693
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date: Fri Feb 2 12:51:10 2018 +0000
gdb/testsuite: Remove use of dejagnu cleanup proc
The 'cleanup' proc has been removed from dejagnu (Feb 15 2016). The
proc has not done anything useful since at least 2001 so removing
these calls should be harmless.
gdb/testsuite/ChangeLog:
* config/sid.exp (gdb_target_sid): Remove use of cleanup.
* config/sim.exp (gdb_target_sim): Remove use of cleanup.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/config/sid.exp | 2 --
gdb/testsuite/config/sim.exp | 1 -
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 0251584..0af50b0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-02-03 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * config/sid.exp (gdb_target_sid): Remove use of cleanup.
+ * config/sim.exp (gdb_target_sim): Remove use of cleanup.
+
2018-02-01 Simon Marchi <simon.marchi@polymtl.ca>
Leszek Swirski <leszeks@google.com>
diff --git a/gdb/testsuite/config/sid.exp b/gdb/testsuite/config/sid.exp
index 36bd861..8ff0263 100644
--- a/gdb/testsuite/config/sid.exp
+++ b/gdb/testsuite/config/sid.exp
@@ -146,7 +146,6 @@ proc gdb_target_sid { } {
gdb_expect {
-re ".*\[Ee\]rror.*$gdb_prompt $" {
perror "Couldn't set target for remote simulator."
- cleanup
gdb_exit
}
-re "Remote debugging using.*$gdb_prompt" {
@@ -154,7 +153,6 @@ proc gdb_target_sid { } {
}
timeout {
perror "Couldn't set target for remote simulator."
- cleanup
gdb_exit
}
}
diff --git a/gdb/testsuite/config/sim.exp b/gdb/testsuite/config/sim.exp
index 7170a25..d9072fe 100644
--- a/gdb/testsuite/config/sim.exp
+++ b/gdb/testsuite/config/sim.exp
@@ -34,7 +34,6 @@ proc gdb_target_sim { } {
}
timeout {
perror "Couldn't set target for simulator."
- cleanup
return -1
}
}