[binutils-gdb] Remove regcache_xmalloc

[Tom Tromey <tromey at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=791199cc75fd294a4f5a228f83abdcbfb4c64c7e

commit 791199cc75fd294a4f5a228f83abdcbfb4c64c7e
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Sep 23 14:39:56 2017 -0600

    Remove regcache_xmalloc
    
    This patch removes regcache_xmalloc in favor of plain "new".
    
    gdb/ChangeLog
    2017-09-25  Tom Tromey  <tom@tromey.com>
    
    	* regcache.h (regcache_xmalloc): Don't declare.
    	(regcache_raw_set_cached_value): Update comment.
    	* regcache.c (regcache_xmalloc): Remove.
    	* ppc-linux-tdep.c (ppu2spu_sniffer): Use new.
    	* jit.c (jit_frame_sniffer): Use new.
    	* frame.c (frame_save_as_regcache): Use new.

Diff:
---
 gdb/ChangeLog        | 9 +++++++++
 gdb/frame.c          | 4 ++--
 gdb/jit.c            | 2 +-
 gdb/ppc-linux-tdep.c | 2 +-
 gdb/regcache.c       | 6 ------
 gdb/regcache.h       | 4 +---
 6 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b6283f6..b42a38f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2017-09-25  Tom Tromey  <tom@tromey.com>
+
+	* regcache.h (regcache_xmalloc): Don't declare.
+	(regcache_raw_set_cached_value): Update comment.
+	* regcache.c (regcache_xmalloc): Remove.
+	* ppc-linux-tdep.c (ppu2spu_sniffer): Use new.
+	* jit.c (jit_frame_sniffer): Use new.
+	* frame.c (frame_save_as_regcache): Use new.
+
 2017-09-25  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
 	* NEWS: Advertise support for guarded-storage registers on IBM z.
diff --git a/gdb/frame.c b/gdb/frame.c
index f100da3..ad0cb92 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1021,8 +1021,8 @@ struct regcache *
 frame_save_as_regcache (struct frame_info *this_frame)
 {
   struct address_space *aspace = get_frame_address_space (this_frame);
-  struct regcache *regcache = regcache_xmalloc (get_frame_arch (this_frame),
-						aspace);
+  struct regcache *regcache = new regcache (get_frame_arch (this_frame),
+					    aspace);
   struct cleanup *cleanups = make_cleanup_regcache_xfree (regcache);
 
   regcache_save (regcache, do_frame_register_read, this_frame);
diff --git a/gdb/jit.c b/gdb/jit.c
index fbfee99..6eea38f 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -1205,7 +1205,7 @@ jit_frame_sniffer (const struct frame_unwind *self,
 
   *cache = XCNEW (struct jit_unwind_private);
   priv_data = (struct jit_unwind_private *) *cache;
-  priv_data->regcache = regcache_xmalloc (gdbarch, aspace);
+  priv_data->regcache = new regcache (gdbarch, aspace);
   priv_data->this_frame = this_frame;
 
   callbacks.priv_data = priv_data;
diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index df664ea..4c851eb 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -1363,7 +1363,7 @@ ppu2spu_sniffer (const struct frame_unwind *self,
 	    = FRAME_OBSTACK_CALLOC (1, struct ppu2spu_cache);
 
 	  struct address_space *aspace = get_frame_address_space (this_frame);
-	  struct regcache *regcache = regcache_xmalloc (data.gdbarch, aspace);
+	  struct regcache *regcache = new regcache (data.gdbarch, aspace);
 	  struct cleanup *cleanups = make_cleanup_regcache_xfree (regcache);
 	  regcache_save (regcache, ppu2spu_unwind_register, &data);
 	  discard_cleanups (cleanups);
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 4ef9151..2a92cf0 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -241,12 +241,6 @@ regcache_get_ptid (const struct regcache *regcache)
   return regcache->ptid ();
 }
 
-struct regcache *
-regcache_xmalloc (struct gdbarch *gdbarch, struct address_space *aspace)
-{
-  return new regcache (gdbarch, aspace);
-}
-
 void
 regcache_xfree (struct regcache *regcache)
 {
diff --git a/gdb/regcache.h b/gdb/regcache.h
index eb0454a..877ed59 100644
--- a/gdb/regcache.h
+++ b/gdb/regcache.h
@@ -37,8 +37,6 @@ extern struct regcache *get_thread_arch_aspace_regcache (ptid_t,
 
 void regcache_xfree (struct regcache *regcache);
 struct cleanup *make_cleanup_regcache_xfree (struct regcache *regcache);
-struct regcache *regcache_xmalloc (struct gdbarch *gdbarch,
-				   struct address_space *aspace);
 
 /* Return REGCACHE's ptid.  */
 
@@ -84,7 +82,7 @@ extern LONGEST regcache_raw_get_signed (struct regcache *regcache,
 /* Set a raw register's value in the regcache's buffer.  Unlike
    regcache_raw_write, this is not write-through.  The intention is
    allowing to change the buffer contents of a read-only regcache
-   allocated with regcache_xmalloc.  */
+   allocated with new.  */
 
 extern void regcache_raw_set_cached_value
   (struct regcache *regcache, int regnum, const gdb_byte *buf);