This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Use unique_xmalloc_ptr in env_execute_cli_command


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e91a1fa7d49482565b5f96a2ca9e51ce6327c4ae

commit e91a1fa7d49482565b5f96a2ca9e51ce6327c4ae
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Aug 13 10:57:05 2017 -0600

    Use unique_xmalloc_ptr in env_execute_cli_command
    
    Change env_execute_cli_command to use unique_xmalloc_ptr, removing a
    cleanup.
    
    ChangeLog
    2017-09-03  Tom Tromey  <tom@tromey.com>
    
    	* mi/mi-cmd-env.c (env_execute_cli_command): Use
    	gdb::unique_xmalloc_ptr.

Diff:
---
 gdb/ChangeLog       |  5 +++++
 gdb/mi/mi-cmd-env.c | 12 ++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 73847c5..72b52f5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2017-09-03  Tom Tromey  <tom@tromey.com>
 
+	* mi/mi-cmd-env.c (env_execute_cli_command): Use
+	gdb::unique_xmalloc_ptr.
+
+2017-09-03  Tom Tromey  <tom@tromey.com>
+
 	* thread.c (print_thread_info_1): Use string_printf.
 	(thread_apply_command, thread_apply_all_command): Use
 	std::string.
diff --git a/gdb/mi/mi-cmd-env.c b/gdb/mi/mi-cmd-env.c
index bf4578c..f24f387 100644
--- a/gdb/mi/mi-cmd-env.c
+++ b/gdb/mi/mi-cmd-env.c
@@ -48,17 +48,13 @@ env_execute_cli_command (const char *cmd, const char *args)
 {
   if (cmd != 0)
     {
-      struct cleanup *old_cleanups;
-      char *run;
+      gdb::unique_xmalloc_ptr<char> run;
 
       if (args != NULL)
-	run = xstrprintf ("%s %s", cmd, args);
+	run.reset (xstrprintf ("%s %s", cmd, args));
       else
-	run = xstrdup (cmd);
-      old_cleanups = make_cleanup (xfree, run);
-      execute_command ( /*ui */ run, 0 /*from_tty */ );
-      do_cleanups (old_cleanups);
-      return;
+	run.reset (xstrdup (cmd));
+      execute_command ( /*ui */ run.get (), 0 /*from_tty */ );
     }
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]