This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Add ATTRIBUTE_PRINTF to trace_start_error
- From: Simon Marchi <simark at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 17 Jun 2017 21:23:31 -0000
- Subject: [binutils-gdb] Add ATTRIBUTE_PRINTF to trace_start_error
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1d4fbac99e05c2d2ea98984f9bc6f7d7f1a183b7
commit 1d4fbac99e05c2d2ea98984f9bc6f7d7f1a183b7
Author: Simon Marchi <simon.marchi@ericsson.com>
Date: Sat Jun 17 23:19:25 2017 +0200
Add ATTRIBUTE_PRINTF to trace_start_error
clang complains that the fmt passed to vwarning in trace_start_error is
not a literal. This looks like a fair warning, which can be removed by
adding ATTRIBUTE_PRINTF to the declaration of trace_start_error.
gdb/ChangeLog:
* nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/nat/fork-inferior.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a08c781..85ee3cf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2017-06-17 Simon Marchi <simon.marchi@ericsson.com>
+ * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF.
+
+2017-06-17 Simon Marchi <simon.marchi@ericsson.com>
+
* configure: Re-generate.
* warning.m4 (build_warnings): Add -Wno-mismatched-tags.
diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h
index 10e3832..d369cff 100644
--- a/gdb/nat/fork-inferior.h
+++ b/gdb/nat/fork-inferior.h
@@ -95,7 +95,7 @@ extern void gdb_flush_out_err ();
(i.e., when the "traceme_fun" callback is called on fork_inferior)
and bail out. This function does not return. */
extern void trace_start_error (const char *fmt, ...)
- ATTRIBUTE_NORETURN;
+ ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
/* Like "trace_start_error", but the error message is constructed by
combining STRING with the system error message for errno. This