This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Include <signal.h> on gdbserver/fork-child.c (and fix regressions)


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9845682bda4149b5b3648f2d49a041aef5bc1af5

commit 9845682bda4149b5b3648f2d49a041aef5bc1af5
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Fri Jun 9 18:16:19 2017 -0400

    Include <signal.h> on gdbserver/fork-child.c (and fix regressions)
    
    Hi,
    
    This is another obvious patch that fixes a thinko from my previous
    startup-with-shell series.  We should conditionally include <signal.h>
    on gdb/gdbserver/fork-child.c because gdbserver will be putting the
    inferior's terminal on the correct mode after the call to
    fork_inferior, and for that it needs to ignore SIGTTOU.
    
    This patch fixes a bunch of regressions happening on AArch64 that were
    reported by Yao.
    
    gdb/gdbserver/ChangeLog:
    2017-06-09  Sergio Durigan Junior  <sergiodj@redhat.com>
    
    	* fork-child.c: Conditionally include <signal.h>.

Diff:
---
 gdb/gdbserver/ChangeLog    | 4 ++++
 gdb/gdbserver/fork-child.c | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index a5effe2..80240ff 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2017-06-09  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* fork-child.c: Conditionally include <signal.h>.
+
 2017-06-07  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	* server.c (handle_general_set): Handle new packet
diff --git a/gdb/gdbserver/fork-child.c b/gdb/gdbserver/fork-child.c
index a1a8ff1..1002620 100644
--- a/gdb/gdbserver/fork-child.c
+++ b/gdb/gdbserver/fork-child.c
@@ -19,6 +19,9 @@
 #include "server.h"
 #include "job-control.h"
 #include "nat/fork-inferior.h"
+#ifdef HAVE_SIGNAL_H
+#include <signal.h>
+#endif
 
 #ifdef SIGTTOU
 /* A file descriptor for the controlling terminal.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]