This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix PR 21352: Command tsave does not support -r argument
- From: Sergio Durigan Junior <sergiodj at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 5 Apr 2017 16:31:46 -0000
- Subject: [binutils-gdb] Fix PR 21352: Command tsave does not support -r argument
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4a596fe20e93109300e841a3d0ee5f198146ab6d
commit 4a596fe20e93109300e841a3d0ee5f198146ab6d
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Wed Apr 5 12:28:30 2017 -0400
Fix PR 21352: Command tsave does not support -r argument
This is an obvious fix for PR 21352. The problem is that the argument
parsing loop is not using an "else if" where it should, and therefore
the '-r' option ends up unrecognized by GDB.
gdb/ChangeLog:
2017-04-05 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/21352
* tracefile.c (tsave_command): Fix argument parsing for '-r'
option.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/tracefile.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c3999b6..4141beb 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2017-04-05 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ PR gdb/21352
+ * tracefile.c (tsave_command): Fix argument parsing for '-r'
+ option.
+
2017-04-05 Yao Qi <yao.qi@linaro.org>
* frame.c (frame_unwind_register_unsigned): Call
diff --git a/gdb/tracefile.c b/gdb/tracefile.c
index 641ad4d..cc90945 100644
--- a/gdb/tracefile.c
+++ b/gdb/tracefile.c
@@ -325,7 +325,7 @@ tsave_command (char *args, int from_tty)
{
if (strcmp (*argv, "-r") == 0)
target_does_save = 1;
- if (strcmp (*argv, "-ctf") == 0)
+ else if (strcmp (*argv, "-ctf") == 0)
generate_ctf = 1;
else if (**argv == '-')
error (_("unknown option `%s'"), *argv);