This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix obvious gotcha in string comparison
- From: Luis Machado <luisgpm at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 24 Oct 2016 22:45:25 -0000
- Subject: [binutils-gdb] Fix obvious gotcha in string comparison
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=010ece9c47f1ac08c9436b133a74472713dd709b
commit 010ece9c47f1ac08c9436b133a74472713dd709b
Author: Luis Machado <lgustavo@codesourcery.com>
Date: Mon Oct 24 17:44:56 2016 -0500
Fix obvious gotcha in string comparison
This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.
As is, it could lead to crashes.
gdb/ChangeLog:
2016-10-24 Luis Machado <lgustavo@codesourcery.com>
* exec.c (exception_print_same): Fix string comparison to use
statically-allocated ones.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/exec.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index be72369..388cc1f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-24 Luis Machado <lgustavo@codesourcery.com>
+
+ * exec.c (exception_print_same): Fix string comparison to use
+ statically-allocated ones.
+
2016-10-21 Tom Tromey <tom@tromey.com>
* dwarf2expr.h (class dwarf_expr_context)
diff --git a/gdb/exec.c b/gdb/exec.c
index d858e99..67ecc63 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -152,7 +152,7 @@ exception_print_same (struct gdb_exception e1, struct gdb_exception e2)
return (e1.reason == e2.reason
&& e1.error == e2.error
- && strcmp (e1.message, e2.message) == 0);
+ && strcmp (msg1, msg2) == 0);
}
/* See gdbcore.h. */