This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] testsuite: Fix gdb.base/killed-outside.exp using irrelevant stale options


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2d2476aac71fcafad6d1524733f0d88f2b53753b

commit 2d2476aac71fcafad6d1524733f0d88f2b53753b
Author: Maciej W. Rozycki <macro@imgtec.com>
Date:   Wed Oct 19 18:20:54 2016 +0100

    testsuite: Fix gdb.base/killed-outside.exp using irrelevant stale options
    
    Fix a commit 4a556533cf02 ("Fix PR11094: JIT breakpoint is not properly
    recreated on reruns") regression:
    
    Running .../gdb/testsuite/gdb.base/killed-outside.exp ...
    Executing on host: mips-mti-linux-gnu-gcc  -Wl,--no-as-needed  -c -g  -o .../gdb/testsuite/outputs/gdb.base/killed-outside/killed-outside0.o .../gdb/testsuite/gdb.base/killed-outside.c .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so    (timeout = 300)
    spawn mips-mti-linux-gnu-gcc -Wl,--no-as-needed -c -g -o .../gdb/testsuite/outputs/gdb.base/killed-outside/killed-outside0.o .../gdb/testsuite/gdb.base/killed-outside.c .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so
    mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done
    output is:
    mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done
    
    gdb compile failed, mips-mti-linux-gnu-gcc: warning: .../gdb/testsuite/outputs/gdb.base/jit-simple/jit-simple-jit.so: linker input file unused because linking not done
    UNTESTED: gdb.base/killed-outside.exp: failed to prepare
    
    and adjust the call to `prepare_for_testing' by removing a reference to
    `options', which is not set in this test case but a stale value is
    carried over from `gdb.base/jit-simple.exp' previously executed in a
    full test suite run.
    
    	gdb/testsuite/
    	* gdb.base/killed-outside.exp: Remove $options from a call to
    	`prepare_for_testing'.

Diff:
---
 gdb/testsuite/ChangeLog                   | 5 +++++
 gdb/testsuite/gdb.base/killed-outside.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 4ecf0b7..5409537 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-19  Maciej W. Rozycki  <macro@imgtec.com>
+
+    	* gdb.base/killed-outside.exp: Remove $options from a call to
+    	`prepare_for_testing'.
+
 2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
diff --git a/gdb/testsuite/gdb.base/killed-outside.exp b/gdb/testsuite/gdb.base/killed-outside.exp
index c69dc0e..2720052 100644
--- a/gdb/testsuite/gdb.base/killed-outside.exp
+++ b/gdb/testsuite/gdb.base/killed-outside.exp
@@ -80,7 +80,7 @@ proc test {cmds_after_kill} {
     }
 }
 
-if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options] == -1} {
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile] == -1} {
     return -1
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]