This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Initialize 'ra' to zero to avoid uninitialized use.
- From: John Baldwin <jhb at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 14 Jun 2016 18:54:31 -0000
- Subject: [binutils-gdb] Initialize 'ra' to zero to avoid uninitialized use.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bec734b212d68d96560e309f49a584d98b98fbdc
commit bec734b212d68d96560e309f49a584d98b98fbdc
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Jun 11 07:26:09 2016 -0700
Initialize 'ra' to zero to avoid uninitialized use.
If the instruction in this case does not include an RA field, then 'ra'
is used uninitialized. Use the same idiom used elsewhere in this file of
initializing ra to zero before check for an RA field.
gdb/ChangeLog:
* rs6000-tdep.c (ppc_process_record_op31): Initialize ra.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/rs6000-tdep.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1bd309f..c0d4a3f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-06-14 John Baldwin <jhb@FreeBSD.org>
+
+ * rs6000-tdep.c (ppc_process_record_op31): Initialize ra.
+
2016-06-13 Nick Clifton <nickc@redhat.com>
* gdbtypes.c (replace_type): Fix assertion.
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 645fe92..1ed1354 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -4631,6 +4631,7 @@ ppc_process_record_op31 (struct gdbarch *gdbarch, struct regcache *regcache,
|| at_dcsz == 0)
at_dcsz = 128; /* Assume 128-byte cache line size (POWER8) */
+ ra = 0;
if (PPC_RA (insn) != 0)
regcache_raw_read_unsigned (regcache,
tdep->ppc_gp0_regnum + PPC_RA (insn), &ra);