This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] sim: moxie: fix leakage in error path [BZ #18273]
- From: Michael Frysinger <vapier at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 11 Oct 2015 07:59:11 -0000
- Subject: [binutils-gdb] sim: moxie: fix leakage in error path [BZ #18273]
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7d8a636c9a234354c9b2ecf01b6e405bece190a1
commit 7d8a636c9a234354c9b2ecf01b6e405bece190a1
Author: Mike Frysinger <vapier@gentoo.org>
Date: Sun Oct 11 03:56:22 2015 -0400
sim: moxie: fix leakage in error path [BZ #18273]
Reported-by: dcb <dcb314@hotmail.com>
Diff:
---
sim/moxie/ChangeLog | 5 +++++
sim/moxie/interp.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog
index fe37e82..04b74ce 100644
--- a/sim/moxie/ChangeLog
+++ b/sim/moxie/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-11 Mike Frysinger <vapier@gentoo.org>
+
+ PR sim/18273
+ * interp.c (load_dtb): Close open file in error path.
+
2015-06-23 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
diff --git a/sim/moxie/interp.c b/sim/moxie/interp.c
index 35ee2a7..df92cee 100644
--- a/sim/moxie/interp.c
+++ b/sim/moxie/interp.c
@@ -1273,6 +1273,7 @@ load_dtb (SIM_DESC sd, const char *filename)
if (size != fread (buf, 1, size, f))
{
sim_io_eprintf (sd, "ERROR: error reading ``%s''.\n", filename);
+ fclose (f);
return;
}
sim_core_write_buffer (sd, scpu, write_map, buf, 0xE0000000, size);