This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Fix inverted statements in m88k_analyze_prologue


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f5cdf4989e5daff1ca8a500d22cbf2eb0692616e

commit f5cdf4989e5daff1ca8a500d22cbf2eb0692616e
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Thu Aug 27 09:47:14 2015 -0400

    Fix inverted statements in m88k_analyze_prologue
    
    These two statements were inverted by mistake in commit "Replace some
    xmalloc-family functions with XNEW-family ones".  It obviously doesn't
    make sense to have them in this order, which is why I am pushing this as
    obvious.
    
    gdb/ChangeLog:
    
    	* m88k-tdep.c (m88k_analyze_prologue): Fix inverted allocation
    	statements.

Diff:
---
 gdb/ChangeLog   | 5 +++++
 gdb/m88k-tdep.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b2d6c91..b572271 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2015-08-27  Simon Marchi  <simon.marchi@ericsson.com>
 
+	* m88k-tdep.c (m88k_analyze_prologue): Fix inverted allocation
+	statements.
+
+2015-08-27  Simon Marchi  <simon.marchi@ericsson.com>
+
 	* NEWS: Document support for non-8-bits addressable memory.
 
 2015-08-27  Pedro Alves  <palves@redhat.com>
diff --git a/gdb/m88k-tdep.c b/gdb/m88k-tdep.c
index 47a8f57..abfd082 100644
--- a/gdb/m88k-tdep.c
+++ b/gdb/m88k-tdep.c
@@ -533,9 +533,9 @@ m88k_analyze_prologue (struct gdbarch *gdbarch,
   /* Provide a dummy cache if necessary.  */
   if (cache == NULL)
     {
-      cache->saved_regs
-	= XALLOCAVEC (struct trad_frame_saved_reg, M88K_R31_REGNUM + 1);
       cache = XALLOCA (struct m88k_frame_cache);
+      cache->saved_regs =
+        XALLOCAVEC (struct trad_frame_saved_reg, M88K_R31_REGNUM + 1);
 
       /* We only initialize the members we care about.  */
       cache->saved_regs[M88K_R1_REGNUM].addr = -1;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]