This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove xfail in gdb.mi/mi-watch.exp


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=da33c9a7bff093e772a381bf9ab42d876089cdcf

commit da33c9a7bff093e772a381bf9ab42d876089cdcf
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Mon Jul 27 15:02:10 2015 -0400

    Remove xfail in gdb.mi/mi-watch.exp
    
    I noticed there was an unexpected pass in mi-watch.exp when running on
    x86_64.  Doing a bit of archeology shows that the xfail was added by
    4a543da.  This particular test failed on the MIPS architecture, which
    the original contributor was working with.  Here is the thread:
    
    https://www.sourceware.org/ml/gdb-patches/2007-09/msg00151.html
    
    Looking at the latest buildbot results for MIPS, it seems that it's also
    an unexpected pass on that architecture.  Therefore, I see no reason to
    leave the xfail in place.
    
    gdb/testsuite/ChangeLog:
    
    	* gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.

Diff:
---
 gdb/testsuite/ChangeLog           | 4 ++++
 gdb/testsuite/gdb.mi/mi-watch.exp | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 818ea30..73bc2b6 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-07-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
+
 2015-07-27  Patrick Palka  <patrick@parcs.ath.cx>
 
 	* gdb.base/gdb-sigterm-2.exp: New test.
diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
index 2551d42..4f87a5a 100644
--- a/gdb/testsuite/gdb.mi/mi-watch.exp
+++ b/gdb/testsuite/gdb.mi/mi-watch.exp
@@ -131,14 +131,10 @@ proc test_watchpoint_triggering {type} {
         {"" "wpt=\{number=\"2\",exp=\"C\"\},value=\{old=\".*\",new=\"3\"\}"} \
         "watchpoint trigger"
 
-    if { $type == "sw" } {
-      setup_xfail *-*-*
-    }
     mi_execute_to "exec-continue" "watchpoint-scope" "callee3" ".*" \
         ".*basics.c" $line_callee3_close_brace \
         {"" "wpnum=\"2\""} \
         "watchpoint trigger"
-    clear_xfail *-*-*
 }
 
 proc test_watchpoint_all {type} {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]