This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Initialize EXPR in dtrace-probe::dtrace_process_dof_probe
- From: Joel Brobecker <brobecke at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 27 Mar 2015 15:26:00 -0000
- Subject: [binutils-gdb] Initialize EXPR in dtrace-probe::dtrace_process_dof_probe
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=79498702ef5f743481ee39c18418776715addcd6
commit 79498702ef5f743481ee39c18418776715addcd6
Author: Joel Brobecker <brobecker@adacore.com>
Date: Fri Mar 27 06:37:34 2015 -0700
Initialize EXPR in dtrace-probe::dtrace_process_dof_probe
GCC 4.4.7 generates the following warning:
| cc1: warnings being treated as errors
| dtrace-probe.c: In function â??dtrace_process_dof_probeâ??:
| dtrace-probe.c:416: error: â??exprâ?? may be used uninitialized in this function
| make[2]: *** [dtrace-probe.o] Error 1
Later versions (GCC 5) do a better job and don't generate the warning,
but it does not hurt to pre-initialize "expr" to NULL.
gdb/ChangeLog:
* dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/dtrace-probe.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3ef965c..72940b0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-27 Joel Brobecker <brobecker@adacore.com>
+
+ * dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL.
+
2015-03-27 Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
* gdb_bfd.c (gdb_bfd_section_index): Fix off-by-one for special
diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c
index ff7ce7d..3f2548d 100644
--- a/gdb/dtrace-probe.c
+++ b/gdb/dtrace-probe.c
@@ -413,7 +413,7 @@ dtrace_process_dof_probe (struct objfile *objfile,
for (j = 0; j < ret->probe_argc; j++)
{
struct dtrace_probe_arg arg;
- struct expression *expr;
+ struct expression *expr = NULL;
/* Set arg.expr to ensure all fields in expr are initialized and
the compiler will not warn when arg is used. */