This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] PR remote/17946: Fix wrong comparison of pointer against char
- From: Sergio Durigan Junior <sergiodj at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 10 Feb 2015 00:01:19 -0000
- Subject: [binutils-gdb] PR remote/17946: Fix wrong comparison of pointer against char
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0b24eb2de5a6dbefe48fd57fcf5d0e7fb24895d4
commit 0b24eb2de5a6dbefe48fd57fcf5d0e7fb24895d4
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Mon Feb 9 18:58:12 2015 -0500
PR remote/17946: Fix wrong comparison of pointer against char
We were comparing a pointer against a char on remote.c. 'dcb' filed a
bug to inform us about that. I pushed the following patch under the
obvious rule.
gdb/ChangeLog:
2015-02-09 Sergio Durigan Junior <sergiodj@redhat.com>
PR remote/17946
* gdb/remote.c (remote_parse_stop_reply): Fix wrong comparison
of pointer against char.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/remote.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7b989d8..be32f3e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-09 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ PR remote/17946
+ * gdb/remote.c (remote_parse_stop_reply): Fix wrong comparison
+ of pointer against char.
+
2015-02-09 Mark Wielaard <mjw@redhat.com>
* c-typeprint.c (cp_type_print_method_args): Handle '_Atomic'.
diff --git a/gdb/remote.c b/gdb/remote.c
index 3980aad..dbfc10b 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -5682,7 +5682,7 @@ Packet: '%s'\n"),
{
p++;
- if (p == '\0')
+ if (*p == '\0')
;
else if (strncmp (p,
"process:", sizeof ("process:") - 1) == 0)