This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog ser-base.c ser-base.h ser-go ...


CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-04-19 15:26:17

Modified files:
	gdb            : ChangeLog ser-base.c ser-base.h ser-go32.c 
	                 serial.c serial.h 

Log message:
	serial_write: change prototype to take a void-pointer buffer.
	
	While remote.c works with "char *" buffers most of the time, other
	remote targets have binary-ish-er protocols, and choose to use
	"unsigned char" throughout, like e.g., remote-mips.c or
	remote-m32r-sdi.c.  That results in -Wpointer-sign warnings in those
	targets, unless we add casts in calls to serial_write.  Since
	serial_write is only concerned about sending raw host bytes out, and
	serial_ops->write_prim already works with "void *"/"size_t", a similar
	interface to the "write" or "send" system calls, I find it natural to
	change serial_write's prototype accordingly, avoiding the need for
	casts.
	
	Tested on x86_64 Fedora 17, and also by building x86_64-mingw32
	and DJGPP/go32 -hosted gdbs.
	
	gdb/
	2013-04-19  Pedro Alves  <palves@redhat.com>
	
	* ser-base.c (ser_base_write): Change prototype -- take 'void *'
	buffer and size_t size.  Adjust.
	* ser-base.h (ser_base_write): Adjust.
	* ser-go32.c (cnts): Change type to size_t.
	(dos_write): Change prototype -- take 'void *'
	buffer and size_t size.  Adjust.
	(dos_info): Print elements of 'cnts' as unsigned long.
	* serial.c (serial_write): Likewise.
	* serial.h (serial_write): Adjust.
	(struct serial_ops) <write>: Change prototype -- take 'void *'
	buffer and size_t size.  Adjust.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15444&r2=1.15445
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ser-base.c.diff?cvsroot=src&r1=1.26&r2=1.27
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ser-base.h.diff?cvsroot=src&r1=1.14&r2=1.15
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ser-go32.c.diff?cvsroot=src&r1=1.31&r2=1.32
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/serial.c.diff?cvsroot=src&r1=1.54&r2=1.55
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/serial.h.diff?cvsroot=src&r1=1.35&r2=1.36


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]