This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
src/gdb/testsuite ChangeLog gdb.base/list.exp
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: Thu, 28 Mar 2013 11:44:00 +0000
- Subject: src/gdb/testsuite ChangeLog gdb.base/list.exp
CVSROOT: /cvs/src
Module name: src
Branch: gdb_7_6-branch
Changes by: palves@sourceware.org 2013-03-28 11:44:00
Modified files:
gdb/testsuite : ChangeLog
gdb/testsuite/gdb.base: list.exp
Log message:
list.exp: Catch "set listsize" failures (and "set listsize -1/0"'s history).
Before the changes starting at
http://sourceware.org/ml/gdb-patches/2012-08/msg00020.html, the 'set
listsize' command only accepted "0" as special value, meaning
"unlimited". The testsuite actually tried "set listsize -1" and
expected that to mean unlimited too.
If you tried testing list.exp at the time of that patch above,
you'd get:
(gdb) PASS: gdb.base/list.exp: list line 10 with listsize 100
set listsize 0
(gdb) PASS: gdb.base/list.exp: setting listsize to 0 #6
show listsize
Number of source lines gdb will list by default is unlimited.
(gdb) PASS: gdb.base/list.exp: show listsize unlimited #6
list 1
1 #include "list0.h"
2
...
42 /* Not used for anything */
43 }
(gdb) PASS: gdb.base/list.exp: listsize of 0 suppresses output
set listsize -1
integer 4294967295 out of range
(gdb) PASS: gdb.base/list.exp: setting listsize to -1 #7
show listsize
Number of source lines gdb will list by default is unlimited.
(gdb) PASS: gdb.base/list.exp: show listsize unlimited #7
list 1
1 #include "list0.h"
Notice that "set listsize -1" actually failed with "integer 4294967295
out of range", but we issued a PASS anyway.
(and notice how the "listsize of 0 suppresses output" test passes bogusly too.)
This patch fixes that testsuite problem in the obvious way.
gdb/testsuite/
2013-03-28 Pedro Alves <palves@redhat.com>
* gdb.base/list.exp (set_listsize): Use gdb_test_no_output for
"set listsize".
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.3580.2.6&r2=1.3580.2.7
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/list.exp.diff?cvsroot=src&only_with_tag=gdb_7_6-branch&r1=1.34&r2=1.34.2.1