This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog annotate.c annotate.h event- ...


CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-01-22 20:17:10

Modified files:
	gdb            : ChangeLog annotate.c annotate.h event-top.c 

Log message:
	With some changes to how software single-step (SSS) breakpoints are
	handled, one of those being to place SSS breakpoints on the breakpoint
	chain as all other breakpoints, annota1.exp times out with lots and
	lots of breakpoint-invalid and frame-changed annotations.  All those
	extra annotations are actually unnecessary.  For one, SSS breakpoints
	are internal breakpoints, so the frontend shouldn't care if they were
	added, removed or changed.  Then, there's really no point in emitting
	"breakpoints-invalid" or "frames-invalid" more than once between times
	the frontend/user can actually issues GDB commands; the frontend will
	have to wait for the GDB prompt to refresh its state, so emitting
	those annotations at most once between prompts is enough.  Non-stop or
	async would complicate this, but no frontend will be using annotations
	in those modes (one of goes of emacs switching to MI was non-stop mode
	support, AFAIK).  The previous patch reveals there has been an
	intention in the past to suppress multiple breakpoints-invalid
	annotations caused by ignore count changes.  As the previous patch
	shows, that's always been broken, but in any case, this patch actually
	makes it work.  The next patch will remove several annotation-specific
	calls in breakpoint.c in favor of always using the breakpoint modified
	& friends observers, and that causes yet more of these annotations,
	because several calls to the corresponding annotate_* functions in
	breakpoint.c are missing, particularly in newer code.
	
	So all in all, here's a simple mechanism that avoids sending the same
	annotation to the frontend more than once until gdb is ready to accept
	further commands.
	
	Tested on x86_64 Fedora 17.
	
	2013-01-22  Pedro Alves  <palves@redhat.com>
	
	* annotate.c: Include "inferior.h".
	(frames_invalid_emitted)
	(breakpoints_invalid_emitted): New globals.
	(async_background_execution_p): New function.
	(annotate_breakpoints_changed, annotate_frames_invalid): Skip
	emitting the annotation if it has already been emitted.
	(annotate_display_prompt): New function.
	* annotate.h (annotate_display_prompt): New declaration.
	* event-top.c: Include annotate.h.
	(display_gdb_prompt): Call annotate_display_prompt.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15055&r2=1.15056
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/annotate.c.diff?cvsroot=src&r1=1.30&r2=1.31
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/annotate.h.diff?cvsroot=src&r1=1.20&r2=1.21
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/event-top.c.diff?cvsroot=src&r1=1.90&r2=1.91


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]