This is the mail archive of the gas2@sourceware.cygnus.com mailing list for the gas2 project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

A bug fix for common symbol in the ELF linker?

Hi,

This is the patch for the common symbol bug in ELF I reported
earlier. I hope it won't break anything.

Thanks.

H.J.
===================================================================
RCS file: /home/cvs/gnu/binutils/bfd/elflink.h,v
retrieving revision 1.3
diff -c -r1.3 elflink.h
*** 1.3	1995/08/24 01:32:34
--- elflink.h	1995/10/04 02:15:07
***************
*** 153,159 ****
  				    false, false, false);
  	  if (h == (struct elf_link_hash_entry *) NULL)
  	    continue;
! 	  if (h->root.type != bfd_link_hash_undefined)
  	    {
  	      if (h->root.type != bfd_link_hash_undefweak)
  		defined[i] = true;
--- 153,161 ----
  				    false, false, false);
  	  if (h == (struct elf_link_hash_entry *) NULL)
  	    continue;
! 	  /* We should check both undef and common symbols. H.J. */
! 	  if (h->root.type != bfd_link_hash_undefined &&
! 		h->root.type != bfd_link_hash_common)
  	    {
  	      if (h->root.type != bfd_link_hash_undefweak)
  		defined[i] = true;