This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 1/2] libdwfl: elf_from_remote_memory should use pagesize, not p_align.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 10 Mar 2014 21:32:20 +0100
- Subject: Re: [PATCH 1/2] libdwfl: elf_from_remote_memory should use pagesize, not p_align.
On Thu, 2014-03-06 at 22:11 +0100, Jan Kratochvil wrote:
> On Mon, 03 Mar 2014 15:31:27 +0100, Mark Wielaard wrote:
> > --- a/libdwfl/elf-from-memory.c
> > +++ b/libdwfl/elf-from-memory.c
> [...]
> > @@ -195,21 +200,28 @@ elf_from_remote_memory (GElf_Addr ehdr_vma,
> > bool found_base = false;
> > switch (ehdr.e32.e_ident[EI_CLASS])
> > {
>
> The return value could be documented.
>
> > - inline void handle_segment (GElf_Addr vaddr, GElf_Off offset,
> > - GElf_Xword filesz, GElf_Xword align)
> > + inline bool handle_segment (GElf_Addr vaddr, GElf_Off offset,
> > + GElf_Xword filesz, GElf_Xword palign)
Added documentation for both handle_segments nested functions.
> I agree with the patch.
Pushed with extra docs.
Thanks,
Mark