This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] nm.c: Remove unused if/else
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 11 May 2011 10:52:08 +0200
- Subject: Re: [PATCH] nm.c: Remove unused if/else
On Tue, May 10, 2011 at 10:39:07PM +0200, Marek Polacek wrote:
> FWIW, this removes the always true if and also the never executed else branch.
> Maybe that unused branch is there for some particular reason, but if not,
> I think it can be removed. Should I apply?
>
> 2011-05-10 Marek Polacek <mpolacek@redhat.com>
>
> * nm.c (show_symbols_sysv): Remove unused if branch.
As far as I can see by a quick scan over the rest of the code,
the fullname string will always have the same format as in the
unused branch case when we are inspecting an ar archive.
So, I don't know if there is any particular reason for it.
Except to maybe double check the formats are then always the
same. It seems safe to just remove it.
Cheers,
Mark