Re: [PATCH 2/2] libdwfl: Add minisymtab support.

[Mark Wielaard <mjw at redhat dot com>]

On Sun, 2012-12-23 at 10:46 +0100, Jan Kratochvil wrote:
> On Sat, 22 Dec 2012 22:50:03 +0100, Mark Wielaard wrote:
> > That said it shouldn't be hard to interweave
> > the tables so that locals from both come before the globals of both
> 
> You have even easier task here as minidebuginfo is ever combined only with
> .dynsym and .dynsym never contains local symbols.

I thought that was true, but in practice there seem to be some local
symbols in dynsym anyway (in shared libraries or pie executables). So I
wrote some tests to make sure the interweaving was done correctly and
also found I made the mistake to use the zero/empty entry from both
tables twice and I had an off-by-one error... The new tests contain an
example where dynsym has local symbols, and they show the original
tables and the result you get now using dwfl_module_getsym and
dwfl_module_addrsym. I rebased all patches on the mjw/minisymtab branch
against current master. I will post the patches as followup to this
message for review.

Thanks,

Mark