This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: Some elfutils/libdw/cfi comments
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 31 May 2010 16:58:29 +0200
- Subject: Re: Some elfutils/libdw/cfi comments
On Mon, 2010-05-31 at 16:39 +0200, Mark Wielaard wrote:
> - dwarf_next_cfi () has the following comment:
> "On success, returns 0 and fills in *ENTRY; use dwarf_cfi_cie_p to
> see whether ENTRY->cie or ENTRY->fde is valid."
> But dwarf_cfi_cie_p is only defined in the private cfi.h header.
This patch moves the definition into the public header.
OK to push that change?
>From 886df2f93a7b5d2008aec17bb99b7473b56ea505 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Mon, 31 May 2010 15:39:15 +0200
Subject: [PATCH] Move dwarf_cfi_cie_p definition from cfi.h to libdw.h.
---
libdw/ChangeLog | 5 +++++
libdw/cfi.h | 2 --
libdw/libdw.h | 2 ++
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 0400781..a2dd303 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,3 +1,8 @@
+2010-05-31 Mark Wielaard <mjw@redhat.com>
+
+ * cfi.h (dwarf_cfi_cie_p): Move definition from here, to ..
+ * libdw.h (dwarf_cfi_cie_p): ... here.
+
2010-05-28 Eduardo Santiago <santiago@redhat.com>
* dwarf_getlocation.c (dwarf_getlocation): Do attr_ok check first
diff --git a/libdw/cfi.h b/libdw/cfi.h
index e04e76d..6aaa9c8 100644
--- a/libdw/cfi.h
+++ b/libdw/cfi.h
@@ -54,8 +54,6 @@
#include "libelfP.h"
struct ebl;
-#define dwarf_cfi_cie_p(entry) ((entry)->cie.CIE_id == DW_CIE_ID_64)
-
/* Cached CIE representation. */
struct dwarf_cie
{
diff --git a/libdw/libdw.h b/libdw/libdw.h
index 94320c7..252361f 100644
--- a/libdw/libdw.h
+++ b/libdw/libdw.h
@@ -247,6 +247,8 @@ typedef union
Dwarf_FDE fde;
} Dwarf_CFI_Entry;
+#define dwarf_cfi_cie_p(entry) ((entry)->cie.CIE_id == DW_CIE_ID_64)
+
/* Opaque type representing a frame state described by CFI. */
typedef struct Dwarf_Frame_s Dwarf_Frame;
--
1.6.5.2