This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: run-elflint-self.sh fails on alpha
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 11 Mar 2011 13:03:47 +0100
- Subject: Re: run-elflint-self.sh fails on alpha
On Thu, 2011-03-10 at 09:28 -0800, Roland McGrath wrote:
> It probably makes sense for the hook to get all the arguments that
> check_special_symbol gets too, so it can check some details of the specific
> symbol rather than just generically for known bits. Hmm, perhaps even just
> having check_special_symbol do this would be OK too, though that might be
> too coarse since it's used in several places.
Yeah, that seems overkill, since all it really does is check whether the
bit pattern is acceptable. check_special_symbol could get new
functionality added, but that only makes sense if you also check other
semantics, which we aren't doing here.
> If it is a new hook, then
> it might be better for it to get st_other & ~GELF_ST_VISIBILITY so that
> the backend only has to check for the machine-specific bits instead of
> also encoding the generic knowledge.
yes, good point. I made that change on the mjw/ebl_special_other branch.
OK the merge to trunk?
Thanks,
Mark