Re: [PATCH] Add support for Tilera TILE-Gx processor.

[Mark Wielaard <mjw at redhat dot com>]

On Mon, 2012-08-20 at 11:37 -0400, Jeff Kenton wrote:
> 2. Changelog:
> 
>    backends/
>      *Makefile.am: added tilegx processor.
>      *tilegx_corenote.c: new file.
>      *tilegx_regs.c: new file.
>      *tilegx_reloc.def: new file.
>      *tilegx_init.c: new file.
>      *tilegx_retval.c: new file.
>      *tilegx_symbol.c: new file.
>    libebl/
>      *eblopenbackend.c: added tilegx processor.
>    src/
>      *elflint.c: added tilegx processor.
>    tests/
>      *run-allregs.sh: added testfile60 for tilegx processor.
>      *testfile60.bz2: new file.

Please just include those in the ChangeLog files. It should look
something like the attached ChangeLog.diff.

> 1 of 88 tests failed

So that is the only failure. Good.

> -## Copyright (C) 2000-2010 Red Hat, Inc.
> +## Copyright (C) 2000-2012 Red Hat, Inc.

You should add a correct Copyright line. You/Tilera made the changes and
so holds copyright on them. Please add a new Copyright line just after
this line with the current year and the copyright holder. In new files
you write from scratch just have only you/Tilera as copyright holder.

> +#if 0
> +ssize_t
> +arm_register_info (Ebl *ebl __attribute__ ((unused)),
> +                  int regno, char *name, size_t namelen,
> +                  const char **prefix, const char **setname,
> +                  int *bits, int *type)
> +{
> +  switch (regno)
> +    {
> +    case 13 ... 15:
> +      *type = DW_ATE_address;
> +      name[0] = "slp"[regno - 13];
> +      name[1] = "prc"[regno - 13];
> +      namelen = 2;
> +      break;
> +
> +    case 128:
> +      *type = DW_ATE_unsigned;
> +      return stpcpy (name, "spsr") + 1 - name;
> +    }
> +
> +  name[namelen++] = '\0';
> +  return namelen;
> +}
> +#endif

That should not be there.

Thanks,

Mark

diff --git a/backends/ChangeLog b/backends/ChangeLog
index 744d1d5..3250a88 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,17 @@
+2012-08-21  Jeff Kenton  <jkenton@tilera.com>
+
+	* Makefile.am (modules): Add tilegx.
+	(libebl_pic): Add libebl_tilegx_pic.a.
+	(tilegx_SRCS): New variable.
+	(libebl_tilegx_pic_a_SOURCES): Likewise.
+	(am_libebl_tilegx_pic_a_OBJECTS): Likewise.
+	* tilegx_corenote.c: New file.
+	* tilegx_regs.c: New file.
+	* tilegx_reloc.def: New file.
+	* tilegx_init.c: New file.
+	* tilegx_retval.c: New file.
+	* tilegx_symbol.c: New file.
+
 2011-03-09  Mark Wielaard  <mjw@redhat.com>
 
 	* alpha_init.c (alpha_init): Initialize check_st_other_bits hook.
diff --git a/libebl/ChangeLog b/libebl/ChangeLog
index 941ed6f..6a043fa 100644
--- a/libebl/ChangeLog
+++ b/libebl/ChangeLog
@@ -1,3 +1,7 @@
+2012-08-21  Jeff Kenton  <jkenton@tilera.com>
+
+	* eblopenbackend.c (machines): Add tilegx.
+
 2011-06-26  Mark Wielaard  <mjw@redhat.com>
 
 	* eblopenbackend.c (default_debugscn_p): Add .debug_macro.
diff --git a/src/ChangeLog b/src/ChangeLog
index 725554d..4a5144c 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2012-08-21  Jeff Kenton  <jkenton@tilera.com>
+
+	* elflint.c (valid_e_machine): Add EM_TILEGX and EM_TILEPRO.
+
 2012-08-16  Mark Wielaard  <mjw@redhat.com>
 
 	* readelf.c (dwarf_tag_name): Renamed from dwarf_tag_string.
diff --git a/tests/ChangeLog b/tests/ChangeLog
index f0c83e6..d308489 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2012-08-21  Jeff Kenton  <jkenton@tilera.com>
+
+	* testfile60.bz2: New testfile.
+	* run-allregs.sh: Run reg_test testfile60.
+
 2012-08-16  Mark Wielaard  <mjw@redhat.com>
 
 	* allregs.c (dwarf_encoding_string): Rewritten using known-dwarf