This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patchv2] Fix false FAILs on testsuite with ulimit -c unlimited.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Sat, 18 Jan 2014 21:34:41 +0100
- Subject: Re: [patchv2] Fix false FAILs on testsuite with ulimit -c unlimited.
On Sat, Jan 18, 2014 at 09:01:57PM +0100, Jan Kratochvil wrote:
> On Wed, 15 Jan 2014 18:20:49 +0100, Mark Wielaard wrote:
> > I admit it wasn't immediately obvious to me why we were letting the
> > child dump core in this case.
>
> BTW it is a regression since
> 70c3a53baa06b6cdee6e92bd673c1cf977066bc1
> tests: Don't use ptrace detach stopped trick. Raise can return.
>
> Although previously it was not much correct as it left the SIGSTOPped process
> to be reparented to PID 1 which somehow correctly discarded it.
aha, that does make sense.
> > So please at least add a comment here why we are forcefully killing the
> > child. But I think a nicer fix would be to just let the child exit
> > normally after raise () returns.
>
> The stack is corrupt at this point but OK, it can be done.
>
> tests/
> 2014-01-18 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix false FAILs on testsuite with ulimit -c unlimited.
> * backtrace-child.c (sigusr2): Call pthread_exit.
> (main): Return, do not call abort.
Yes, looks good.
Thanks,
Mark