This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 17 Aug 2012 01:03:11 +0200
- Subject: Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
On Thu, 2012-08-16 at 14:38 -0700, Roland McGrath wrote:
> > +# Make sure there are no unknown DWARF codes.
> > +testrun_on_self_nomatch "\?\?\?\ \([x0-9]+\)|lo_user\+0x[0-9a-f]+" ../src/readelf -N -w
>
> There's no need for \ before a space.
Removed.
> Use single-quotes anywhere you
> don't have a reason to use double-quotes in a shell script. It's
> especially unclear when using backslashes inside double-quotes, where
> some will get stripped and others won't.
single-quotes it is.
> > + if test $grep_ok == 0; then
>
> Single = in test.
OK.
> > + exit_status=1;
>
> Superfluous ;.
Removed.
Thanks,
Mark