Re: [PATCH] [portability] avoid nested functions

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 20 September 2013 13:36:03 Josh Stone wrote:
> On 09/19/2013 12:38 PM, Mike Frysinger wrote:
> > +#define lock_dup_elf() \
> > +  ({ \
> > +    /* We need wrlock to dup an archive.  */ \
> > +    if (ref->kind == ELF_K_AR) \
> > +      { \
> > +	rwlock_unlock (ref->lock); \
> > +	rwlock_wrlock (ref->lock); \
> > +      } \
> > +    /* Duplicate the descriptor.  */ \
> > +    return dup_elf (fildes, cmd, ref); \
> > +  })
> 
> Careful - the nested function just returned from itself, whereas your
> macro will try to return from everything.  But this doesn't compile
> anyway, because a return leaves the stmt-expr with a void value:

odd, that's not the version i added to Gentoo.  must have forgot to squash the 
return fix into this one.
-mike

Attachment: signature.asc
Description: PGP signature