This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] debuginfod: Check the DEBUGINFOD_URLS environment variable early in client.
- From: Mark Wielaard <mark at klomp dot org>
- To: elfutils-devel at sourceware dot org
- Date: Wed, 11 Dec 2019 22:34:42 +0100
- Subject: Re: [PATCH] debuginfod: Check the DEBUGINFOD_URLS environment variable early in client.
- References: <20191209184920.10647-1-mark@klomp.org>
On Mon, 2019-12-09 at 19:49 +0100, Mark Wielaard wrote:
> If the debuginfod-client isn't configured we should do as little
> as possible. Simply return early with ENOSYS if no servers are
> configured. This means we won't check
>
> This does change the behavior of the debuginfod_find calls slightly.
> Previously we would setup and check the cache if the given build-id
> was valid. Which might have provided a result if an earlier client
> had run with the same cache and valid server URLs which knew about
> that particular build-id. Now we don't return any cached results
> unless at least one server is configured.
>
> This prevents selinux errors when the library is used in a confined
> setup.
This was tested in Fedora and Frank independently came up with almost
the same fix. Pushed to master.
Cheers,
Mark