Re: [PATCHv1 0/2] specify a sysroot to search when examining a core file

[Mark Wielaard <mark at klomp dot org>]

Hi Luke,

On Sun, Jan 20, 2019 at 03:00:42PM +0000, Luke Diamand wrote:
> Following on from this discussion:
>     https://sourceware.org/ml/elfutils-devel/2018-q4/msg00224.html
> 
> This patch adds a new API to specify a sysroot, and extends eu-stack to
> use it with a new command line option.
> 
> I have been experimenting with this on various ARM-based platforms,
> currently using a virt-qemu platform built from buildroot.

I like it! Thanks.
Some high level comments, before I review the actual code.

- It currently only works for resolving path names found
  in core files. It might make sense to use the same for
  other variants of dwfl_report_xxx and maybe add a
  dwfl_get_sysroot () to be used inside the find_elf
  callback. This can probably be added later though.

- eu-stack uses its own argument parser, but other tools,
  like addr2line, use the argp parser dwfl_standard_argp ().
  It would be nice to add a --sysroot argument parser there
  too that would automatically call dwfl_set_sysroot to
  make them handle --sysroot automagically.

- Is there a way to have some small testcase for this?

Cheers,

Mark