This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3] Cast pid_t to long long when printing

From: Mark Wielaard <mark at klomp dot org>
To: Ulf Hermann <ulf dot hermann at qt dot io>
Cc: elfutils-devel at sourceware dot org
Date: Fri, 18 Aug 2017 23:54:43 +0200
Subject: Re: [PATCH v3] Cast pid_t to long long when printing
Authentication-results: sourceware.org; auth=none
References: <47fb818e-8ade-bb8f-3588-6eb8595f5612@qt.io>

On Fri, Aug 18, 2017 at 05:20:02PM +0200, Ulf Hermann wrote:
> We don't know sizeof(pid_t) as it's not specified in any standard. In
> order to still print it, we cast to long long, the largest integer type
> we can easily print.

That is surprising. But then printing it as long long is as good as
any other choice. I did tweak the patch a little so there is always
a space after the cast and no line gets longer than 80 chars.

Thanks,

Mark

Attachment: 0001-Cast-pid_t-to-long-long-when-printing.patch
Description: Text document

References:
- [PATCH v3] Cast pid_t to long long when printing
  - From: Ulf Hermann

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]