This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] ppc64: Add HTM SPRs support to readelf
- From: Mark Wielaard <mark at klomp dot org>
- To: Gustavo Romero <gromero at linux dot vnet dot ibm dot com>
- Cc: elfutils-devel at sourceware dot org
- Date: Fri, 21 Jul 2017 21:55:46 +0200
- Subject: Re: [PATCH] ppc64: Add HTM SPRs support to readelf
- Authentication-results: sourceware.org; auth=none
- References: <1500587342-21923-1-git-send-email-gromero@linux.vnet.ibm.com>
On Thu, 2017-07-20 at 17:49 -0400, Gustavo Romero wrote:
> Since POWER8, PowerPC 64 supports Hardware Transactional Memory, which has
> three special purpose registers associated to it: tfhar, tfiar, and texasr.
> This commit add HTM SPRs set as known note type so it's possible to use
> 'readelf --notes' to inspect the HTM SPRs in a coredump file generated in
> such a machines.
This patch looks perfect, thanks.
One nitpick.
> diff --git a/libelf/ChangeLog b/libelf/ChangeLog
> index 594bec9..e5529e9 100644
> --- a/libelf/ChangeLog
> +++ b/libelf/ChangeLog
> @@ -1,3 +1,7 @@
> +2017-07-19 Gustavo Romero <gromero@linux.vnet.ibm.com>
> +
> + * elf.h: Add known type in notes segment descriptor for HTM SPRs.
> +
> 2017-04-20 Ulf Hermann <ulf.hermann@qt.io>
>
> * libelfP.h: Don't include config.h.
> diff --git a/libelf/elf.h b/libelf/elf.h
> index b6112d9..fa35203 100644
> --- a/libelf/elf.h
> +++ b/libelf/elf.h
> @@ -763,6 +763,7 @@ typedef struct
> #define NT_PPC_SPE 0x101 /* PowerPC SPE/EVR registers */
> #define NT_PPC_VSX 0x102 /* PowerPC VSX registers */
> #define NT_386_TLS 0x200 /* i386 TLS slots (struct user_desc) */
> +#define NT_PPC_TM_SPR 0x10c /* PowerPC HW Transactional Memory SPRs */
> #define NT_386_IOPERM 0x201 /* x86 io permission bitmap (1=deny) */
> #define NT_X86_XSTATE 0x202 /* x86 extended state using xsave */
> #define NT_S390_HIGH_GPRS 0x300 /* s390 upper register halves */
We normally keep elf.h in sync with glibc.
Could you submit this elf.h change to libc-alpha@sourceware.org?
Then we resync elf.h from glibc to pull in the new constants.
Thanks,
Mark