This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Check for existence of asprintf and vasprintf
- From: Ulf Hermann <ulf dot hermann at qt dot io>
- To: elfutils-devel at sourceware dot org
- Date: Wed, 22 Feb 2017 17:45:16 +0100
- Subject: Re: [PATCH] Check for existence of asprintf and vasprintf
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kY2NYf9CF9HJzN2Ajf83Dx5ilEJPY1RUDmBnCnpW4bA=; b=Tl+KNt+stc4JaEWBJrnXelADaUJQzh+TvJW7NB4NSOrLUYzqSisKkBseKACEzjab6Y0rwhzuoNNsQr/JprQBguLRwP/hkL/BFaXqIekm5TDacNMBzqhkdHtTnEJZxoW6pvj43qCiUKQhKPMKVZ4ASNW8u3vPOOJ/SqXoAyuHtlU=
- References: <4efb45a7-3035-67eb-d61e-62e795afd881@qt.io> <20170222144004.GV28432@vapier> <3716c28b-6478-ee4d-50cf-0ef43e8196f3@qt.io> <20170222163249.GW28432@vapier>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> imo, elfutils shouldn't be growing these fallback implementations itself.
> if you want to do this stuff, use gnulib instead.
>
> then there is no ifdef hell in the source files, and you don't have to
> worry about testing whether the ifdef's are correct because gnulib did
> it all for you.
OK, so I won't post any more patches with replacement functions. I don't like the idea of using gnulib because the gnulib implementations are generally more complex and in order to maintain them I would have to track gnulib in addition to elfutils. Also I would have to review the licenses for each import. This is not something I'm excited to do for a few 3-line functions. But OK, I will consider it.
What about switching off functionality if certain conditions aren't met? For example the patch that allows us to build libelf and libdw if argp is not available. Are such changes acceptable? I have something similar for obstack, and possibly for fts.
Ulf